From 37ca839b29414d30c04079544bb010a80bba3f13 Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Wed, 18 Jun 2014 10:16:58 +0530 Subject: [PATCH] Update user report view settings on field_rename --- frappe/model/__init__.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/frappe/model/__init__.py b/frappe/model/__init__.py index 4c6e8e5a6d..45b42ef38c 100644 --- a/frappe/model/__init__.py +++ b/frappe/model/__init__.py @@ -113,7 +113,7 @@ def rename_field(doctype, old_fieldname, new_fieldname): where doc_type=%s and field_name=%s""", (new_fieldname, doctype, old_fieldname)) update_reports(doctype, old_fieldname, new_fieldname) - update_users_report_view_settings(doctype, old_fieldname) + update_users_report_view_settings(doctype, old_fieldname, new_fieldname) def update_reports(doctype, old_fieldname, new_fieldname): def _get_new_sort_by(report_dict, report, key): @@ -175,7 +175,7 @@ def update_reports(doctype, old_fieldname, new_fieldname): frappe.db.sql("""update `tabReport` set `json`=%s where name=%s""", (new_val, r.name)) -def update_users_report_view_settings(doctype, ref_fieldname): +def update_users_report_view_settings(doctype, ref_fieldname, new_fieldname): user_report_cols = frappe.db.sql("""select defkey, defvalue from `tabDefaultValue` where defkey like '_list_settings:%'""") for key, value in user_report_cols: @@ -183,8 +183,11 @@ def update_users_report_view_settings(doctype, ref_fieldname): columns_modified = False for field, field_doctype in json.loads(value): if field == ref_fieldname and field_doctype == doctype: - new_columns.append([field, field_doctype]) + new_columns.append([new_fieldname, field_doctype]) columns_modified=True + else: + new_columns.append([field, field_doctype]) + if columns_modified: frappe.db.sql("""update `tabDefaultValue` set defvalue=%s where defkey=%s""" % ('%s', '%s'), (json.dumps(new_columns), key))