From 37d8e2bb366c8a9c1f349d8cc1fbec99727b1c6f Mon Sep 17 00:00:00 2001 From: David Date: Tue, 11 Jun 2024 19:34:20 +0200 Subject: [PATCH] perf: lazy load svg sprictes on websites --- frappe/hooks.py | 5 ++++- frappe/templates/base.html | 12 ++++++++++-- .../doctype/website_settings/website_settings.py | 2 +- 3 files changed, 15 insertions(+), 4 deletions(-) diff --git a/frappe/hooks.py b/frappe/hooks.py index d29f2167a9..7a97b3ece8 100644 --- a/frappe/hooks.py +++ b/frappe/hooks.py @@ -43,8 +43,11 @@ doctype_js = { } web_include_js = ["website_script.js"] - web_include_css = [] +web_include_icons = [ + "frappe/icons/timeless/icons.svg", + "frappe/icons/espresso/icons.svg", +] email_css = ["email.bundle.css"] diff --git a/frappe/templates/base.html b/frappe/templates/base.html index 2c992c082f..375f80e8c2 100644 --- a/frappe/templates/base.html +++ b/frappe/templates/base.html @@ -44,6 +44,7 @@ - {% include "public/icons/timeless/icons.svg" %} - {% include "public/icons/espresso/icons.svg" %} {%- block banner -%} {% include "templates/includes/banner_extension.html" ignore missing %} @@ -90,10 +89,19 @@ {% block base_scripts %} + {{ include_script('frappe-web.bundle.js') }} {% endblock %} diff --git a/frappe/website/doctype/website_settings/website_settings.py b/frappe/website/doctype/website_settings/website_settings.py index 567c56f1d6..695c37ee3f 100644 --- a/frappe/website/doctype/website_settings/website_settings.py +++ b/frappe/website/doctype/website_settings/website_settings.py @@ -229,8 +229,8 @@ def get_website_settings(context=None): context.encoded_title = quote(encode(context.title or ""), "") context.web_include_js = hooks.web_include_js or [] - context.web_include_css = hooks.web_include_css or [] + context.web_include_icons = hooks.web_include_icons or [] via_hooks = hooks.website_context or [] for key in via_hooks: