vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: only update URL if active list is still same

Browse source 
If you rapidly move from a list view while it was being refreshed then
changed URL is applied on a page that MIGHT not be the list/report view.

This check ensures that same page is present before updating URL.
This commit is contained in:
Ankush Menat 2022-07-05 16:29:43 +05:30
parent 261fbfcd11
commit 39c5d0d454
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
frappe/public/js/frappe/list/list_view.js
View file

@ -1456,7 +1456,10 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
on_update() {}
update_url_with_filters() {
window.history.replaceState(null, null, this.get_url_with_filters());
if (frappe.get_route_str() == this.page_name) {
// only update URL if the route still matches current page.
window.history.replaceState(null, null, this.get_url_with_filters());
}
}
get_url_with_filters() {

4
frappe/public/js/frappe/views/reports/query_report.js
View file

@ -58,7 +58,9 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList {
}
update_url_with_filters() {
window.history.replaceState(null, null, this.get_url_with_filters());
if (frappe.get_route_str() == this.page_name) {
window.history.replaceState(null, null, this.get_url_with_filters());
}
}
get_url_with_filters() {