From 3a2eb64a2914bb082113986482ce7cb46c14a4bf Mon Sep 17 00:00:00 2001 From: Abhishek Balam Date: Mon, 18 May 2020 23:32:42 +0530 Subject: [PATCH] fix: Console error in generate_google_search_preview() when route is not set VM2249:28 Uncaught (in promise) TypeError: Cannot read property 'split' of undefined at generate_google_search_preview (eval at setup (form.min.js?ver=1589740826.0:15059), :28:34) at refresh (eval at setup (form.min.js?ver=1589740826.0:15059), :10:3) at runner (form.min.js?ver=1589740826.0:14996) at form.min.js?ver=1589740826.0:15014 --- frappe/website/doctype/blog_post/blog_post.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/website/doctype/blog_post/blog_post.js b/frappe/website/doctype/blog_post/blog_post.js index adc03ca77e..138440db2f 100644 --- a/frappe/website/doctype/blog_post/blog_post.js +++ b/frappe/website/doctype/blog_post/blog_post.js @@ -21,7 +21,7 @@ function generate_google_search_preview(frm) { let seo_title = (frm.doc.title).slice(0, 60); let seo_description = (frm.doc.meta_description || frm.doc.blog_intro || "").slice(0, 160); let date = frm.doc.published_on ? new frappe.datetime.datetime(frm.doc.published_on).moment.format('ll') + ' - ' : ''; - let route_array = frm.doc.route.split('/'); + let route_array = (frm.doc.route) ? frm.doc.route.split('/') : []; route_array.pop(); google_preview.html(`