vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

[minor] throttle doc_subscribed

Browse source
This commit is contained in:
Rushabh Mehta 2017-04-29 17:49:46 +05:30
parent 8533306af3
commit 3b2a1227fb
2 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
frappe/public/js/frappe/socketio_client.js
View file

@ -57,15 +57,6 @@ frappe.socket = {
frappe.socket.setup_reconnect();
$(document).on('form-load form-rename', function(e, frm) {
if (frappe.flags.doc_subscribe) {
return;
}
frappe.flags.doc_subscribe = true;
// throttle to 1 per sec
setTimeout(function() { frappe.flags.doc_subscribe = false }, 1000);
if (frm.is_new()) {
return;
}
@ -136,6 +127,16 @@ frappe.socket = {
frappe.socket.socket.emit('task_unsubscribe', task_id);
},
doc_subscribe: function(doctype, docname) {
if (frappe.flags.doc_subscribe) {
console.log('throttled');
return;
}
frappe.flags.doc_subscribe = true;
// throttle to 1 per sec
setTimeout(function() { frappe.flags.doc_subscribe = false }, 1000);
frappe.socket.socket.emit('doc_subscribe', doctype, docname);
frappe.socket.open_docs.push({doctype: doctype, docname: docname});
},

1
socketio.js
View file

@ -204,6 +204,7 @@ function get_url(socket, path) {
function can_subscribe_doc(args) {
if(!args) return;
if(!args.doctype || !args.docname) return;
request.get(get_url(args.socket, '/api/method/frappe.async.can_subscribe_doc'))
.type('form')
.query({