From 3b3b9e7e4a1cd6d40ed186cbff07384eea016c54 Mon Sep 17 00:00:00 2001 From: Sagar Vora Date: Thu, 1 Apr 2021 15:04:51 +0530 Subject: [PATCH] fix: create _get_children for passing ignore_permissions when needed --- frappe/desk/treeview.py | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/frappe/desk/treeview.py b/frappe/desk/treeview.py index e0b6ca240a..12fdb0dadc 100644 --- a/frappe/desk/treeview.py +++ b/frappe/desk/treeview.py @@ -36,20 +36,27 @@ def get_all_nodes(doctype, label, parent, tree_method, **filters): return out @frappe.whitelist() -def get_children(doctype, parent='', **filters): +def get_children(doctype, parent=''): + return _get_children(doctype, parent) + +def _get_children(doctype, parent='', ignore_permissions=False): parent_field = 'parent_' + doctype.lower().replace(' ', '_') - filters=[['ifnull(`{0}`,"")'.format(parent_field), '=', parent], + filters = [['ifnull(`{0}`,"")'.format(parent_field), '=', parent], ['docstatus', '<' ,'2']] - doctype_meta = frappe.get_meta(doctype) - data = frappe.get_list(doctype, fields=[ - 'name as value', - '{0} as title'.format(doctype_meta.get('title_field') or 'name'), - 'is_group as expandable'], - filters=filters, - order_by='name') + meta = frappe.get_meta(doctype) - return data + return frappe.get_list( + doctype, + fields=[ + 'name as value', + '{0} as title'.format(meta.get('title_field') or 'name'), + 'is_group as expandable' + ], + filters=filters, + order_by='name', + ignore_permissions=ignore_permissions + ) @frappe.whitelist() def add_node():