From 3bfc9fa8da3aa3dcb03ff261d8466a08aa30b559 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Sun, 16 Mar 2025 11:05:39 +0530 Subject: [PATCH] perf: Don't update list view settings on every query (#31743) It literally doesn't do anything ever. User settings are explicitly updated using `user_settings.save` endpoint. --- frappe/model/db_query.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/frappe/model/db_query.py b/frappe/model/db_query.py index 0dedeee712..7a47daad4f 100644 --- a/frappe/model/db_query.py +++ b/frappe/model/db_query.py @@ -1142,6 +1142,10 @@ class DatabaseQuery: def update_user_settings(self): # update user settings if new search + if not self.save_user_settings_fields and not getattr(self, "user_settings", None): + # Nothing has changed or needs to be changed + return + user_settings = json.loads(get_user_settings(self.doctype)) if hasattr(self, "user_settings"):