vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

[fix] add validations on payment notification callback

Browse source
This commit is contained in:
Saurabh 2018-10-05 17:16:28 +05:30
parent 32c5f7a011
commit 3ce7ba4e5d
3 changed files with 83 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

55
frappe/integrations/doctype/paypal_settings/paypal_settings.py
View file

@ -68,10 +68,10 @@ import frappe
import json
from frappe import _
from datetime import datetime
from frappe.utils import get_url, call_hook_method, cint, get_timestamp, cstr, now, date_diff, get_datetime
from six.moves.urllib.parse import urlencode
from frappe.model.document import Document
from frappe.integrations.utils import create_request_log, make_post_request, create_payment_gateway
from frappe.utils import get_url, call_hook_method, cint, get_timestamp, cstr, now, date_diff, get_datetime
api_path = '/api/method/frappe.integrations.doctype.paypal_settings.paypal_settings'
@ -363,27 +363,56 @@ def manage_recurring_payment_profile_status(profile_id, action, args, url):
})
response = make_post_request(url, data=args)
if response.get("ACK")[0] != "Success":
frappe.throw(_("Failed while amending subscription"))
@frappe.whitelist(allow_guest=True)
def ipn_handler():
data = frappe.local.form_dict
data.update({
"payment_gateway": "PayPal"
try:
data = frappe.local.form_dict
validate_ipn_request(data)
data.update({
"payment_gateway": "PayPal"
})
doc = frappe.get_doc({
"data": json.dumps(frappe.local.form_dict),
"doctype": "Integration Request",
"status": "Subscription Notification"
}).insert(ignore_permissions=True)
frappe.db.commit()
frappe.enqueue(method='frappe.integrations.doctype.paypal_settings.paypal_settings.handle_subscription_notification',
queue='long', timeout=600, is_async=True, **{"doctype": "Integration Request", "docname": doc.name})
except frappe.InvalidStatusError:
pass
except Exception as e:
frappe.log(frappe.log_error(title=e))
def validate_ipn_request(data):
def _throw():
frappe.throw(_("In Valid Request"), exc=frappe.InvalidStatusError)
if not data.get("recurring_payment_id"):
_throw()
doc = frappe.get_doc("PayPal Settings")
params, url = doc.get_paypal_params_and_url()
params.update({
"METHOD": "GetRecurringPaymentsProfileDetails",
"PROFILEID": data.get("recurring_payment_id")
})
doc = frappe.get_doc({
"data": frappe.local.form_dict,
"doctype": "Integration Request",
"status": "Subscription Notification"
}).insert(ignore_permissions=True)
frappe.db.commit()
params = urlencode(params)
res = make_post_request(url=url, data=params.encode("utf-8"))
frappe.enqueue(method='frappe.integrations.doctype.paypal_settings.paypal_settings.handle_subscription_notification',
queue='long', timeout=600, is_async=True, **{"doctype": "Integration Request", "docname": doc.name})
if res['ACK'][0] != 'Success':
_throw()
def handle_subscription_notification(doctype, docname):
call_hook_method("handle_subscription_notification", doctype=doctype, docname=docname)

53
frappe/integrations/doctype/razorpay_settings/razorpay_settings.py
View file

@ -331,23 +331,50 @@ def convert_rupee_to_paisa(**kwargs):
frappe.conf.converted_rupee_to_paisa = True
@frappe.whitelist(allow_guest=True)
def razorpay_subscription_callback():
data = frappe.local.form_dict
data.update({
"payment_gateway": "Razorpay"
})
try:
data = frappe.local.form_dict
doc = frappe.get_doc({
"data": json.dumps(frappe.local.form_dict),
"doctype": "Integration Request",
"status": "Subscription Notification"
}).insert(ignore_permissions=True)
frappe.db.commit()
validate_payment_callback()
frappe.enqueue(method='frappe.integrations.doctype.razorpay_settings.razorpay_settings.handle_subscription_notification',
queue='long', timeout=600, is_async=True, **{"doctype": "Integration Request", "docname": doc.name})
data.update({
"payment_gateway": "Razorpay"
})
doc = frappe.get_doc({
"data": json.dumps(frappe.local.form_dict),
"doctype": "Integration Request",
"status": "Subscription Notification"
}).insert(ignore_permissions=True)
frappe.db.commit()
frappe.enqueue(method='frappe.integrations.doctype.razorpay_settings.razorpay_settings.handle_subscription_notification',
queue='long', timeout=600, is_async=True, **{"doctype": "Integration Request", "docname": doc.name})
except frappe.InvalidStatusError:
pass
except Exception as e:
frappe.log(frappe.log_error(title=e))
def validate_payment_callback(data):
def _throw():
frappe.throw(_("Invalid Subscription"), exc=frappe.InvalidStatusError)
subscription_id = data.get('payload').get("subscription").get("entity").get("id")
if not(subscription_id):
_throw()
controller = frappe.get_doc("Razorpay Settings")
settings = controller.get_settings(data)
resp = make_get_request("https://api.razorpay.com/v1/subscriptions/{0}".format(subscription_id),
auth=(settings.api_key, settings.api_secret))
if resp.get("status") != "active":
_throw()
def handle_subscription_notification(doctype, docname):
call_hook_method("handle_subscription_notification", doctype=doctype, docname=docname)

2
frappe/integrations/utils.py
View file

@ -112,4 +112,4 @@ def create_payment_gateway(gateway, settings=None, controller=None):
def json_handler(obj):
if isinstance(obj, (datetime.date, datetime.timedelta, datetime.datetime)):
return text_type(obj)
return text_type(obj)