diff --git a/frappe/core/doctype/doctype/doctype.py b/frappe/core/doctype/doctype/doctype.py index 6abc34a035..6a1887f14a 100644 --- a/frappe/core/doctype/doctype/doctype.py +++ b/frappe/core/doctype/doctype/doctype.py @@ -337,7 +337,7 @@ class DocType(Document): "DocField", "parent", dict(fieldtype=["in", frappe.model.table_fields], options=self.name) ) for p in parent_list: - frappe.db.set_value("DocType", p.parent, {}, for_update=False) + frappe.db.set_value("DocType", p.parent, {}) def scrub_field_names(self): """Sluggify fieldnames if not set from Label.""" diff --git a/frappe/tests/test_auth.py b/frappe/tests/test_auth.py index fe8a290a04..d4cfe4451e 100644 --- a/frappe/tests/test_auth.py +++ b/frappe/tests/test_auth.py @@ -50,7 +50,7 @@ class TestAuth(FrappeTestCase): frappe.local.response["http_status_code"] = None def set_system_settings(self, k, v): - frappe.db.set_value("System Settings", "System Settings", k, v) + frappe.db.set_single_value("System Settings", k, v) frappe.clear_cache() frappe.db.commit() diff --git a/frappe/tests/test_db.py b/frappe/tests/test_db.py index afc24ecf68..3d103e3ab5 100644 --- a/frappe/tests/test_db.py +++ b/frappe/tests/test_db.py @@ -192,7 +192,7 @@ class TestDB(FrappeTestCase): # test for inp in test_inputs: fieldname = f"test_{inp['fieldtype'].lower()}" - frappe.db.set_value("Print Settings", "Print Settings", fieldname, inp["value"]) + frappe.db.set_single_value("Print Settings", fieldname, inp["value"]) self.assertEqual(frappe.db.get_single_value("Print Settings", fieldname), inp["value"]) # teardown @@ -201,7 +201,7 @@ class TestDB(FrappeTestCase): def test_log_touched_tables(self): frappe.flags.in_migrate = True frappe.flags.touched_tables = set() - frappe.db.set_value("System Settings", "System Settings", "backup_limit", 5) + frappe.db.set_single_value("System Settings", "backup_limit", 5) self.assertIn("tabSingles", frappe.flags.touched_tables) frappe.flags.touched_tables = set() @@ -699,14 +699,12 @@ class TestDBSetValue(FrappeTestCase): value = frappe.db.get_single_value("System Settings", "deny_multiple_sessions") changed_value = not value - frappe.db.set_value( - "System Settings", "System Settings", "deny_multiple_sessions", changed_value - ) + frappe.db.set_single_value("System Settings", "deny_multiple_sessions", changed_value) current_value = frappe.db.get_single_value("System Settings", "deny_multiple_sessions") self.assertEqual(current_value, changed_value) changed_value = not current_value - frappe.db.set_value("System Settings", None, "deny_multiple_sessions", changed_value) + frappe.db.set_single_value("System Settings", "deny_multiple_sessions", changed_value) current_value = frappe.db.get_single_value("System Settings", "deny_multiple_sessions") self.assertEqual(current_value, changed_value) diff --git a/frappe/tests/test_frappe_client.py b/frappe/tests/test_frappe_client.py index 40ba854b82..c8f3bee3d9 100644 --- a/frappe/tests/test_frappe_client.py +++ b/frappe/tests/test_frappe_client.py @@ -107,7 +107,7 @@ class TestFrappeClient(FrappeTestCase): self.assertEqual( server.get_value("Website Settings", "title_prefix").get("title_prefix"), "test-prefix" ) - frappe.db.set_value("Website Settings", None, "title_prefix", "") + frappe.db.set_single_value("Website Settings", "title_prefix", "") def test_update_doc(self): server = FrappeClient(get_url(), "Administrator", self.PASSWORD, verify=False) diff --git a/frappe/tests/test_website.py b/frappe/tests/test_website.py index 841f7f1e71..6c319fff0a 100644 --- a/frappe/tests/test_website.py +++ b/frappe/tests/test_website.py @@ -43,20 +43,20 @@ class TestWebsite(FrappeTestCase): frappe.db.set_value("Role", "home-page-test", "home_page", "") # home page via portal settings - frappe.db.set_value("Portal Settings", None, "default_portal_home", "test-portal-home") + frappe.db.set_single_value("Portal Settings", "default_portal_home", "test-portal-home") frappe.set_user("test-user-for-home-page@example.com") frappe.cache.hdel("home_page", frappe.session.user) self.assertEqual(get_home_page(), "test-portal-home") - frappe.db.set_value("Portal Settings", None, "default_portal_home", "") + frappe.db.set_single_value("Portal Settings", "default_portal_home", "") clear_website_cache() # home page via website settings - frappe.db.set_value("Website Settings", None, "home_page", "contact") + frappe.db.set_single_value("Website Settings", "home_page", "contact") self.assertEqual(get_home_page(), "contact") - frappe.db.set_value("Website Settings", None, "home_page", None) + frappe.db.set_single_value("Website Settings", "home_page", None) clear_website_cache() # fallback homepage diff --git a/frappe/utils/nestedset.py b/frappe/utils/nestedset.py index 374851e019..01b7576876 100644 --- a/frappe/utils/nestedset.py +++ b/frappe/utils/nestedset.py @@ -221,9 +221,7 @@ def rebuild_node(doctype, parent, left, parent_field): # we've got the left value, and now that we've processed # the children of this node we also know the right value - frappe.db.set_value( - doctype, parent, {"lft": left, "rgt": right}, for_update=False, update_modified=False - ) + frappe.db.set_value(doctype, parent, {"lft": left, "rgt": right}, update_modified=False) # return the right value of this node + 1 return right + 1 @@ -326,7 +324,6 @@ class NestedSet(Document): {"old_parent": newdn}, {parent_field: newdn}, update_modified=False, - for_update=False, ) if merge: