diff --git a/frappe/core/report/permitted_documents_for_user/permitted_documents_for_user.py b/frappe/core/report/permitted_documents_for_user/permitted_documents_for_user.py index 362cc6b105..b8d7ca2a97 100644 --- a/frappe/core/report/permitted_documents_for_user/permitted_documents_for_user.py +++ b/frappe/core/report/permitted_documents_for_user/permitted_documents_for_user.py @@ -38,7 +38,7 @@ def validate(user, doctype): def get_columns_and_fields(doctype): columns = [f"Name:Link/{doctype}:200"] - fields = ["`name`"] + fields = ["name"] for df in frappe.get_meta(doctype).fields: if df.in_list_view and df.fieldtype in data_fieldtypes: fields.append(f"`{df.fieldname}`") diff --git a/frappe/share.py b/frappe/share.py index dfb4836995..7f7ca2033f 100644 --- a/frappe/share.py +++ b/frappe/share.py @@ -104,12 +104,12 @@ def get_users(doctype, name): return frappe.db.get_all( "DocShare", fields=[ - "`name`", - "`user`", - "`read`", - "`write`", - "`submit`", - "`share`", + "name", # Don't understant the need for pseudocolumns here, don't know why get_all supports it? + "user", + "read", + "write", + "submit", + "share", "everyone", "owner", "creation", diff --git a/frappe/tests/test_query.py b/frappe/tests/test_query.py index 5fae35623d..7b9a307e04 100644 --- a/frappe/tests/test_query.py +++ b/frappe/tests/test_query.py @@ -4,7 +4,6 @@ import frappe from frappe.query_builder import Field from frappe.query_builder.functions import Abs, Count, Max, Timestamp from frappe.tests.test_query_builder import db_type_is, run_only_if -from frappe.query_builder.utils import PseudoColumn class TestQuery(unittest.TestCase): @@ -50,7 +49,7 @@ class TestQuery(unittest.TestCase): frappe.qb.from_("User") .select(Field("name"), Field("email")) .where(Field("name") == "Administrator") - .run() + .run(), ) def test_functions_fields(self):