vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor: Use URLSearchParams API for list view filters (#21647)

Browse source 
This gives better data structure to manipulate than simple strings.
This commit is contained in:
Ankush Menat 2023-07-11 20:12:20 +05:30 • committed by GitHub
parent f6751bf415
commit 3de0eb3243
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
frappe/public/js/frappe/list/list_view.js
View file

@ -1544,26 +1544,31 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
}
get_url_with_filters() {
const query_params = this.get_filters_for_args()
.map((filter) => {
if (filter[2] === "=") {
return `${filter[1]}=${encodeURIComponent(filter[3])}`;
}
return [
filter[1],
"=",
encodeURIComponent(JSON.stringify([filter[2], filter[3]])),
].join("");
})
.join("&");
let search_params = this.get_search_params();
let full_url = window.location.href.replace(window.location.search, "");
if (query_params) {
full_url += "?" + query_params;
if (search_params.size) {
full_url += "?" + search_params.toString();
}
return full_url;
}
get_search_params() {
let search_params = new URLSearchParams();
this.get_filters_for_args().forEach((filter) => {
if (filter[2] === "=") {
search_params.append(filter[1], encodeURIComponent(filter[3]));
} else {
search_params.append(
filter[1],
encodeURIComponent(JSON.stringify([filter[2], filter[3]]))
);
}
});
return search_params;
}
get_menu_items() {
const doctype = this.doctype;
const items = [];