Merge pull request #24263 from ankush/fix_perm_message

fix: print perm check logs from DB query
This commit is contained in:
Ankush Menat 2024-01-11 13:31:29 +05:30 committed by GitHub
commit 3e2e10780b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 5 deletions

View file

@ -521,14 +521,13 @@ class DatabaseQuery:
def _set_permission_map(self, doctype: str, parent_doctype: str | None = None):
ptype = "select" if frappe.only_has_select_perm(doctype) else "read"
val = frappe.has_permission(
frappe.has_permission(
doctype,
ptype=ptype,
parent_doctype=parent_doctype or self.doctype,
throw=True,
user=self.user,
)
if not val:
frappe.flags.error_message = _("Insufficient Permission for {0}").format(frappe.bold(doctype))
raise frappe.PermissionError(doctype)
self.permission_map[doctype] = ptype
def set_field_tables(self):

View file

@ -62,7 +62,7 @@ def report_error(status_code):
def _link_error_with_message_log(error_log, exception, message_logs):
for message in message_logs:
if message.get("__frappe_exc_id") == exception.__frappe_exc_id:
if message.get("__frappe_exc_id") == getattr(exception, "__frappe_exc_id", None):
error_log.update(message)
message_logs.remove(message)
error_log.pop("raise_exception", None)