From 3e82f7367296c2abb64aaf478642e1deba0cc0ca Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Tue, 5 May 2015 18:03:22 +0530 Subject: [PATCH] [minor] validate select default is in options --- frappe/core/doctype/doctype/doctype.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/frappe/core/doctype/doctype/doctype.py b/frappe/core/doctype/doctype/doctype.py index 7fdd52bc55..01bdcb16e8 100644 --- a/frappe/core/doctype/doctype/doctype.py +++ b/frappe/core/doctype/doctype/doctype.py @@ -265,6 +265,8 @@ def validate_fields(meta): def check_illegal_default(d): if d.fieldtype == "Check" and d.default and d.default not in ('0', '1'): frappe.throw(_("Default for 'Check' type of field must be either '0' or '1'")) + if d.fieldtype == "Select" and d.default and (d.default not in d.options.split("\n")): + frappe.throw(_("Default for {0} must be an option").format(d.fieldname)) def check_precision(d): if d.fieldtype in ("Currency", "Float", "Percent") and d.precision is not None and not (1 <= cint(d.precision) <= 6):