From fb69f61196f8507181c7160b0c330509358b03d0 Mon Sep 17 00:00:00 2001 From: Ejaaz Khan Date: Mon, 5 Jan 2026 16:26:50 +0530 Subject: [PATCH 1/2] fix(navbar): don't show copy on new doc --- frappe/public/js/frappe/views/breadcrumbs.js | 27 ++++++++++++-------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/frappe/public/js/frappe/views/breadcrumbs.js b/frappe/public/js/frappe/views/breadcrumbs.js index 5b45553daf..6ce9055698 100644 --- a/frappe/public/js/frappe/views/breadcrumbs.js +++ b/frappe/public/js/frappe/views/breadcrumbs.js @@ -221,8 +221,10 @@ frappe.breadcrumbs = { let form_route = `/desk/${frappe.router.slug(doctype)}/${encodeURIComponent(docname)}`; let docname_title; + let is_new_doc = false; if (docname.startsWith("new-" + doctype.toLowerCase().replace(/ /g, "-"))) { docname_title = __("New {0}", [__(doctype)]); + is_new_doc = true; } else { let title = frappe.model.get_doc_title(doc); docname_title = title || doc.name; @@ -239,16 +241,19 @@ frappe.breadcrumbs = { last_crumb.addClass("ellipsis"); last_crumb.find("a").addClass("ellipsis"); } - last_crumb.css("cursor", "copy"); - last_crumb.click((event) => { - event.stopImmediatePropagation(); - frappe.utils.copy_to_clipboard(doc.name); - }); - last_crumb.attr("title", __("Click to copy name")); - last_crumb.tooltip({ - delay: { show: 100, hide: 100 }, - trigger: "hover", - }); + + if (!is_new_doc) { + last_crumb.css("cursor", "copy"); + last_crumb.click((event) => { + event.stopImmediatePropagation(); + frappe.utils.copy_to_clipboard(doc.name); + }); + last_crumb.attr("title", __("Click to copy name")); + last_crumb.tooltip({ + delay: { show: 100, hide: 100 }, + trigger: "hover", + }); + } } }, @@ -276,7 +281,7 @@ frappe.breadcrumbs = { }, clear() { - this.$breadcrumbs = $(".navbar-breadcrumbs").empty(); + this.$breadcrumbs = $($(".navbar-breadcrumbs")[0]).empty(); this.append_breadcrumb_element("/desk", frappe.utils.icon("monitor")); }, From 497aa61ceb009c82d0eb43fa8ca36f1520b478d6 Mon Sep 17 00:00:00 2001 From: Ejaaz Khan Date: Tue, 6 Jan 2026 01:18:32 +0530 Subject: [PATCH 2/2] fix: select element by class --- frappe/public/js/frappe/views/breadcrumbs.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/public/js/frappe/views/breadcrumbs.js b/frappe/public/js/frappe/views/breadcrumbs.js index 6ce9055698..fe54380ca8 100644 --- a/frappe/public/js/frappe/views/breadcrumbs.js +++ b/frappe/public/js/frappe/views/breadcrumbs.js @@ -235,7 +235,7 @@ frappe.breadcrumbs = { this.append_breadcrumb_element(form_route, docname_title, "title-text-form"); if (view === "form") { - let last_crumb = this.$breadcrumbs.find("li").last(); + let last_crumb = this.$breadcrumbs.find(".title-text-form").parent(); last_crumb.addClass("disabled"); if (frappe.is_mobile()) { last_crumb.addClass("ellipsis"); @@ -281,7 +281,7 @@ frappe.breadcrumbs = { }, clear() { - this.$breadcrumbs = $($(".navbar-breadcrumbs")[0]).empty(); + this.$breadcrumbs = $(".navbar-breadcrumbs").empty(); this.append_breadcrumb_element("/desk", frappe.utils.icon("monitor")); },