vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Merge pull request #28553 from cogk/fix-quick-list-add_fields-might-contain-missing-fields

Browse source 
fix(quick_list): Ensure fields exist before fetching
This commit is contained in:
Akhil Narang 2024-11-25 12:56:33 +05:30 • committed by GitHub
commit 3ef785e320
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
frappe/public/js/frappe/widgets/quick_list_widget.js
View file

@ -205,8 +205,13 @@ export default class QuickListWidget extends Widget {
let add_fields = frappe.listview_settings?.[this.document_type]?.add_fields;
if (Array.isArray(add_fields)) {
fields.push(...add_fields);
fields = [...new Set(fields)];
for (const fieldname of add_fields) {
// Only keep fields that exist and are permitted
if (frappe.meta.has_field(this.document_type, fieldname)) {
fields.push(fieldname);
}
}
fields = [...new Set(fields)]; // Remove duplicates
}
let quick_list_filter = frappe.utils.process_filter_expression(this.quick_list_filter);