vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: use Star() instead of Column("*") for correct COUNT(*) SQL

Browse source
This commit is contained in:
Sagar Vora 2025-12-01 23:44:41 +05:30
parent 730f35ab70
commit 3f2fbd7d4e
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frappe/database/query.py
View file

@ -6,7 +6,7 @@ from typing import TYPE_CHECKING, Any
import sqlparse
from pypika.enums import Arithmetic
from pypika.queries import Column, QueryBuilder, Table
from pypika.terms import AggregateFunction, ArithmeticExpression, Term, ValueWrapper
from pypika.terms import AggregateFunction, ArithmeticExpression, Star, Term, ValueWrapper
import frappe
from frappe import _
@ -2032,9 +2032,9 @@ class SQLFunctionParser:
# Special case: allow '*' for COUNT(*) and similar aggregate functions
if arg == "*":
# Return as-is for SQL star expansion (COUNT(*), etc.)
# pypika will handle this correctly when used with aggregate functions
return Column("*")
# Star() produces correct unquoted * for COUNT(*)
# Column("*") would produce COUNT("*") which is wrong
return Star()
# Check for string literals (quoted strings)
if self._is_string_literal(arg):