vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

perf: Don't re-initate sessions in realtime.py

Browse source 
Session is already created for all requests in app.py -> init_request -> HTTPRequest()
This commit is contained in:
Ankush Menat 2023-03-23 16:55:09 +05:30
parent 5a91ac945c
commit 3f717f2fbd
1 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
frappe/realtime.py
View file

@ -105,10 +105,8 @@ def get_redis_server():
@frappe.whitelist(allow_guest=True)
def can_subscribe_doc(doctype: str, docname: str) -> bool:
from frappe.exceptions import PermissionError
from frappe.sessions import Session
session = Session(None, resume=True).get_session_data()
if not frappe.has_permission(user=session.user, doctype=doctype, doc=docname, ptype="read"):
if not frappe.has_permission(doctype=doctype, doc=docname, ptype="read"):
raise PermissionError()
return True
@ -118,7 +116,7 @@ def can_subscribe_doc(doctype: str, docname: str) -> bool:
def can_subscribe_doctype(doctype: str) -> bool:
from frappe.exceptions import PermissionError
if not frappe.has_permission(user=frappe.session.user, doctype=doctype, ptype="read"):
if not frappe.has_permission(doctype=doctype, ptype="read"):
raise PermissionError()
return True
@ -126,13 +124,9 @@ def can_subscribe_doctype(doctype: str) -> bool:
@frappe.whitelist(allow_guest=True)
def get_user_info():
from frappe.sessions import Session
session = Session(None, resume=True).get_session_data()
return {
"user": session.user,
"user_type": session.user_type,
"user": frappe.session.user,
"user_type": frappe.session.user_type,
}