vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: strength check on password control (#19561)

Browse source 
* fix: strength check on password control

* fix: no password strength verification on login
This commit is contained in:
Ankush Menat 2023-01-11 13:13:17 +05:30 • committed by GitHub
parent be23576631
commit 3f82839c53
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
frappe/public/js/frappe/desk.js
View file

@ -447,6 +447,7 @@ frappe.Application = class Application {
}
},
});
dialog.get_field("password").disable_password_checks();
dialog.set_primary_action(__("Login"), () => {
dialog.set_message(__("Authenticating..."));
frappe.call({

21
frappe/public/js/frappe/form/controls/password.js
View file

@ -2,6 +2,7 @@ frappe.ui.form.ControlPassword = class ControlPassword extends frappe.ui.form.Co
static input_type = "password";
make() {
super.make();
this.enable_password_checks = true;
}
make_input() {
var me = this;
@ -23,7 +24,15 @@ frappe.ui.form.ControlPassword = class ControlPassword extends frappe.ui.form.Co
}, 500);
});
}
disable_password_checks() {
this.enable_password_checks = false;
}
get_password_strength(value) {
if (!this.enable_password_checks) {
return;
}
var me = this;
frappe.call({
type: "POST",
@ -32,13 +41,9 @@ frappe.ui.form.ControlPassword = class ControlPassword extends frappe.ui.form.Co
new_password: value || "",
},
callback: function (r) {
if (r.message && r.message.entropy) {
var score = r.message.score,
feedback = r.message.feedback;
feedback.crack_time_display = r.message.crack_time_display;
var indicators = ["grey", "red", "orange", "yellow", "green"];
if (r.message) {
let score = r.message.score;
var indicators = ["red", "red", "orange", "yellow", "green"];
me.set_strength_indicator(indicators[score]);
}
},
@ -47,6 +52,6 @@ frappe.ui.form.ControlPassword = class ControlPassword extends frappe.ui.form.Co
set_strength_indicator(color) {
var message = __("Include symbols, numbers and capital letters in the password");
this.indicator.removeClass().addClass("password-strength-indicator indicator " + color);
this.message.html(message).removeClass("hidden");
this.message.html(message).toggleClass("hidden", color == "green");
}
};

3
frappe/www/update-password.html
View file

@ -161,11 +161,10 @@ frappe.ready(function() {
.text("{{ _('Invalid Password') }}");
},
200: function(r) {
if (r.message && r.message.score) {
if (r.message) {
var score = r.message.score,
feedback = r.message.feedback;
feedback.crack_time_display = r.message.crack_time_display;
feedback.score = score;
if(feedback.password_policy_validation_passed){