From 3fe34b2f1837e8b44a3f8f3879eec15dc58c4bfb Mon Sep 17 00:00:00 2001 From: foolishdino Date: Tue, 10 Sep 2024 16:27:34 +0700 Subject: [PATCH] fix(quick_list_widget):workflow-state-not-showing (#27596) * fix(quick_list_widget):workflow-state-not-showing when a document has workflow state, it should show workflow_status. Instead it doesn't. existing code put a validation if status exist, but a document can have a workflow_state without a "status" field. the correct approach is to separate the logic. * fix(quick_list_widget):follow-suggestioin-to-remove-unnecessary-validation Co-authored-by: Akhil Narang --------- Co-authored-by: Akhil Narang --- frappe/public/js/frappe/widgets/quick_list_widget.js | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/frappe/public/js/frappe/widgets/quick_list_widget.js b/frappe/public/js/frappe/widgets/quick_list_widget.js index d6d2559e5d..bc5b39f031 100644 --- a/frappe/public/js/frappe/widgets/quick_list_widget.js +++ b/frappe/public/js/frappe/widgets/quick_list_widget.js @@ -197,12 +197,10 @@ export default class QuickListWidget extends Widget { if (this.has_status_field) { fields.push("status"); fields.push("docstatus"); - - // add workflow state field if workflow exist & is active - let workflow_fieldname = frappe.workflow.get_state_fieldname(this.document_type); - workflow_fieldname && fields.push(workflow_fieldname); } - + // add workflow state field if workflow exist & is active + let workflow_fieldname = frappe.workflow.get_state_fieldname(this.document_type); + workflow_fieldname && fields.push(workflow_fieldname); fields.push("modified"); let quick_list_filter = frappe.utils.process_filter_expression(this.quick_list_filter);