vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

chore: make communication list exception helpful

Browse source 
* fixes infinite error recursion caused by window.history.back();
* throw an actually useful message instead of using msgprint

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
This commit is contained in:
Chinmay D. Pai 2019-10-10 15:08:40 +05:30
parent fddfaec913
commit 3ff3e71d34
No known key found for this signature in database
GPG key ID: 75507BE256F40CED
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frappe/public/js/frappe/views/inbox/inbox_view.js
View file

@ -17,9 +17,7 @@ frappe.views.InboxView = class InboxView extends frappe.views.ListView {
frappe.set_route("List", "Communication", "Inbox", email_account);
return true;
} else if (!route[3] || (route[3] !== "All Accounts" && !is_valid(route[3]))) {
frappe.msgprint(__('Invalid Email Account'));
window.history.back();
return true;
frappe.throw(__('No email account associated with the User. Please add an account under User > Email Inbox.'));
}
return false;