From 73ccf9e68cd77d41a62f6f1ccbee40e91e61c971 Mon Sep 17 00:00:00 2001 From: Prateeksha Singh Date: Tue, 27 Mar 2018 10:53:40 +0530 Subject: [PATCH] [desktop-icons] sort icon select options, fixes frappe/erpnext#10236 --- .../public/js/frappe/ui/toolbar/modules_select.js | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/frappe/public/js/frappe/ui/toolbar/modules_select.js b/frappe/public/js/frappe/ui/toolbar/modules_select.js index f9dee7976d..aa3b728681 100644 --- a/frappe/public/js/frappe/ui/toolbar/modules_select.js +++ b/frappe/public/js/frappe/ui/toolbar/modules_select.js @@ -61,10 +61,16 @@ frappe.ui.toolbar.ModulesSelect = class { callback: (r) => { const icons = r.message.icons; const user = r.message.user; - resolve(icons.map(icon => { - const uncheck = user ? icon.hidden : icon.blocked; - return { label: icon.value, value: icon.module_name, checked:!uncheck }; - })); + resolve(icons + .map(icon => { + const uncheck = user ? icon.hidden : icon.blocked; + return { label: icon.value, value: icon.module_name, checked:!uncheck }; + }).sort(function(a, b){ + if(a.label < b.label) return -1; + if(a.label > b.label) return 1; + return 0; + }) + ); } }); });