From 4123acfcd1e859e177dc6b649c0f8b0fa4bbd21b Mon Sep 17 00:00:00 2001 From: Clayton Date: Tue, 10 Feb 2026 14:36:02 -0600 Subject: [PATCH] fix: remove unnecessary code --- .../doctype/desktop_layout/desktop_layout.py | 25 ------------------- 1 file changed, 25 deletions(-) diff --git a/frappe/desk/doctype/desktop_layout/desktop_layout.py b/frappe/desk/doctype/desktop_layout/desktop_layout.py index 6e5fd64159..8bc3fa00bc 100644 --- a/frappe/desk/doctype/desktop_layout/desktop_layout.py +++ b/frappe/desk/doctype/desktop_layout/desktop_layout.py @@ -39,8 +39,6 @@ def save_layout(user: str, layout: str, new_icons: str): desktop_layout = frappe.new_doc("Desktop Layout") desktop_layout.user = frappe.session.user - _sync_icon_renames(layout) - if layout: desktop_layout.layout = json.dumps(layout) desktop_layout.save() @@ -61,29 +59,6 @@ def save_layout(user: str, layout: str, new_icons: str): return {"layout": layout} -def _sync_icon_renames(layout): - """Apply label renames from layout to Desktop Icon docs so they persist across refresh.""" - if not layout or not isinstance(layout, list): - return - for icon in layout: - old_name = icon.get("name") - new_label = icon.get("label") - if not old_name or not new_label or old_name == new_label: - continue - if not frappe.db.exists("Desktop Icon", old_name): - continue - # Update children's parent_icon first, then rename the doc - frappe.db.sql( - "update `tabDesktop Icon` set parent_icon = %(new)s where parent_icon = %(old)s", - {"new": new_label, "old": old_name}, - ) - doc = frappe.get_doc("Desktop Icon", old_name) - doc.label = new_label - doc.save() - icon["name"] = new_label - clear_desktop_icons_cache() - - @frappe.whitelist() def get_layout(): """Return the current user's saved desktop layout. Used on desk load to avoid stale cached HTML."""