Merge pull request #920 from pdvyas/validate-jinja-template

Validate jinja2 syntax before saving print format

frappe/core/doctype/print_format/print_format.py

@@ -4,6 +4,7 @@
 from __future__ import unicode_literals
 import frappe
 import frappe.utils
+from jinja2 import TemplateSyntaxError
 
 from frappe.model.document import Document
 
@@ -16,6 +17,12 @@ class PrintFormat(Document):
 		self.old_doc_type = frappe.db.get_value('Print Format',
 				self.name, 'doc_type')
 
+		jenv = frappe.get_jenv()
+		try:
+			jenv.from_string(self.html)
+		except TemplateSyntaxError:
+			frappe.throw(frappe._("Syntax error in Jinja template"))
+
 	def on_update(self):
 		if hasattr(self, 'old_doc_type') and self.old_doc_type:
 			frappe.clear_cache(doctype=self.old_doc_type)

frappe/core/doctype/print_format/test_records.json

@@ -3,6 +3,7 @@
 		"doctype": "Print Format",
 		"name": "_Test Print Format 1",
 		"module": "core",
-		"doc_type": "User"
+		"doc_type": "User",
+		"html": ""
 	}
 ]