From 389e6757647814d94b00f9c190c490b40a719eaf Mon Sep 17 00:00:00 2001 From: Sagar Vora Date: Mon, 5 Dec 2022 00:44:09 +0530 Subject: [PATCH] fix: ensure correct parenttype when retrieving roles --- frappe/permissions.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/frappe/permissions.py b/frappe/permissions.py index 0307952c62..2997165dc9 100644 --- a/frappe/permissions.py +++ b/frappe/permissions.py @@ -427,7 +427,9 @@ def get_roles(user=None, with_standard=True): table = DocType("Has Role") roles = ( frappe.qb.from_(table) - .where((table.parent == user) & (table.role.notin(["All", "Guest"]))) + .where( + (table.parenttype == "User") & (table.parent == user) & (table.role.notin(["All", "Guest"])) + ) .select(table.role) .run(pluck=True) )