vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: Log settings - Handle validation failures (#19549)

Browse source 
There's only one sane way to get past validations - remove the rows, so
just do it instead of asking users to do it.

[skip ci]
This commit is contained in:
Ankush Menat 2023-01-10 12:30:01 +05:30 • committed by GitHub
parent 1eaca4e1d5
commit 41f8fb1a68
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
frappe/core/doctype/log_settings/log_settings.py
View file

@ -42,27 +42,26 @@ def _supports_log_clearing(doctype: str) -> bool:
class LogSettings(Document):
def validate(self):
self.validate_supported_doctypes()
self.validate_duplicates()
self._remove_unsupported_doctypes()
self._deduplicate_entries()
self.add_default_logtypes()
def validate_supported_doctypes(self):
for entry in self.logs_to_clear:
def _remove_unsupported_doctypes(self):
for entry in list(self.logs_to_clear):
if _supports_log_clearing(entry.ref_doctype):
continue
msg = _("{} does not support automated log clearing.").format(frappe.bold(entry.ref_doctype))
if frappe.conf.developer_mode:
msg += "<br>" + _("Implement `clear_old_logs` method to enable auto error clearing.")
frappe.throw(msg, title=_("DocType not supported by Log Settings."))
frappe.msgprint(msg, title=_("DocType not supported by Log Settings."))
self.remove(entry)
def validate_duplicates(self):
def _deduplicate_entries(self):
seen = set()
for entry in self.logs_to_clear:
for entry in list(self.logs_to_clear):
if entry.ref_doctype in seen:
frappe.throw(
_("{} appears more than once in configured log doctypes.").format(entry.ref_doctype)
)
self.remove(entry)
seen.add(entry.ref_doctype)
def add_default_logtypes(self):