From 430c0c7c7aeb33bcdb65fafc43b722de791ef20d Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Thu, 16 Jan 2025 15:50:56 +0530 Subject: [PATCH] fix(DX): Log all exceptions in developer mode (#29195) ALL exceptions - even validation errors. This is excessive logging but in development mode it should be fine and even helpful in debugging few issues. --- frappe/app.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frappe/app.py b/frappe/app.py index 894745895d..110e5262e4 100644 --- a/frappe/app.py +++ b/frappe/app.py @@ -26,7 +26,7 @@ from frappe.auth import SAFE_HTTP_METHODS, UNSAFE_HTTP_METHODS, HTTPRequest, val from frappe.middlewares import StaticDataMiddleware from frappe.utils import CallbackManager, cint, get_site_name from frappe.utils.data import escape_html -from frappe.utils.error import log_error_snapshot +from frappe.utils.error import log_error, log_error_snapshot from frappe.website.page_renderers.error_page import ErrorPage from frappe.website.serve import get_response @@ -390,7 +390,7 @@ def handle_exception(e): if hasattr(frappe.local, "login_manager"): frappe.local.login_manager.clear_cookies() - if http_status_code >= 500: + if http_status_code >= 500 or frappe.conf.developer_mode: log_error_snapshot(e) if frappe.conf.get("developer_mode") and not respond_as_json: