From 43a722d3bbfa33b44504592bba701a2908d6cbb2 Mon Sep 17 00:00:00 2001
From: Aditya Hase <aditya@adityahase.com>
Date: Thu, 28 Oct 2021 15:54:32 +0530
Subject: [PATCH] fix(minor): Don't allow frappe.cache() methods in server
 scripts (#14609)

---
 .../server_script/test_server_script.py       | 21 -------------------
 frappe/utils/safe_exec.py                     | 10 ---------
 2 files changed, 31 deletions(-)

diff --git a/frappe/core/doctype/server_script/test_server_script.py b/frappe/core/doctype/server_script/test_server_script.py
index 100e3c2790..3c091fec0b 100644
--- a/frappe/core/doctype/server_script/test_server_script.py
+++ b/frappe/core/doctype/server_script/test_server_script.py
@@ -69,16 +69,6 @@ frappe.method_that_doesnt_exist("do some magic")
 		disabled = 1,
 		script = '''
 frappe.db.commit()
-'''
-	),
-	dict(
-		name='test_cache_methods',
-		script_type = 'DocType Event',
-		doctype_event = 'Before Save',
-		reference_doctype = 'ToDo',
-		disabled = 1,
-		script = '''
-frappe.cache().set_value('test_key', doc.name)
 '''
 	)
 ]
@@ -149,14 +139,3 @@ class TestServerScript(unittest.TestCase):
 
 		server_script.disabled = 1
 		server_script.save()
-
-	def test_cache_methods_in_server_script(self):
-		server_script = frappe.get_doc('Server Script', 'test_cache_methods')
-		server_script.disabled = 0
-		server_script.save()
-
-		todo = frappe.get_doc(dict(doctype='ToDo', description='test me')).insert()
-		self.assertEqual(todo.name, frappe.cache().get_value('test_key'))
-
-		server_script.disabled = 1
-		server_script.save()
diff --git a/frappe/utils/safe_exec.py b/frappe/utils/safe_exec.py
index 2b8626bee9..cc9662b4eb 100644
--- a/frappe/utils/safe_exec.py
+++ b/frappe/utils/safe_exec.py
@@ -174,8 +174,6 @@ def get_safe_globals():
 			rollback=frappe.db.rollback,
 		)
 
-		out.frappe.cache = cache
-
 	if frappe.response:
 		out.frappe.response = frappe.response
 
@@ -193,14 +191,6 @@ def get_safe_globals():
 
 	return out
 
-def cache():
-	return NamespaceDict(
-		get_value = frappe.cache().get_value,
-		set_value = frappe.cache().set_value,
-		hset = frappe.cache().hset,
-		hget = frappe.cache().hget
-	)
-
 def get_hooks(hook=None, default=None, app_name=None):
 	hooks = frappe.get_hooks(hook=hook, default=default, app_name=app_name)
 	return copy.deepcopy(hooks)