From 43f655bd6b111994ea3c0dcce6bae1821ee6a98d Mon Sep 17 00:00:00 2001
From: sokumon <sohamkulkarns9@gmail.com>
Date: Wed, 11 Mar 2026 13:28:01 +0530
Subject: [PATCH] fix: add icon in settings dropdown

---
 frappe/core/doctype/navbar_item/navbar_item.json | 11 +++++++++--
 frappe/public/js/frappe/ui/menu.js               |  2 +-
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/frappe/core/doctype/navbar_item/navbar_item.json b/frappe/core/doctype/navbar_item/navbar_item.json
index f247b7b7cb..694e7c6952 100644
--- a/frappe/core/doctype/navbar_item/navbar_item.json
+++ b/frappe/core/doctype/navbar_item/navbar_item.json
@@ -10,6 +10,7 @@
   "action",
   "hidden",
   "is_standard",
+  "icon",
   "column_break_dtwu",
   "condition"
  ],
@@ -72,19 +73,25 @@
   {
    "fieldname": "column_break_dtwu",
    "fieldtype": "Column Break"
+  },
+  {
+   "fieldname": "icon",
+   "fieldtype": "Icon",
+   "label": "Icon"
   }
  ],
  "istable": 1,
  "links": [],
- "modified": "2024-11-15 14:12:19.803995",
+ "modified": "2026-03-11 12:23:02.473404",
  "modified_by": "Administrator",
  "module": "Core",
  "name": "Navbar Item",
  "owner": "Administrator",
  "permissions": [],
  "quick_entry": 1,
+ "row_format": "Dynamic",
  "sort_field": "creation",
  "sort_order": "DESC",
  "states": [],
  "track_changes": 1
-}
\ No newline at end of file
+}
diff --git a/frappe/public/js/frappe/ui/menu.js b/frappe/public/js/frappe/ui/menu.js
index 48c060f874..78406fb456 100644
--- a/frappe/public/js/frappe/ui/menu.js
+++ b/frappe/public/js/frappe/ui/menu.js
@@ -57,7 +57,7 @@ frappe.ui.menu = class ContextMenu {
 			if (typeof item.condition == "function") {
 				render = item.condition();
 			} else {
-				render = frappe.utils.eval_expression(item.condition);
+				render = frappe.utils.eval(item.condition);
 			}
 			if (render) {
 				this.add_menu_item(item);