From ac59087f49510e22284a9cb872c8463305bd52be Mon Sep 17 00:00:00 2001
From: s-aga-r <sagarsharma.s312@gmail.com>
Date: Thu, 9 Jun 2022 13:30:55 +0530
Subject: [PATCH] fix: can't create a new User Type

---
 frappe/core/doctype/user_type/user_type.js   |  9 ++------
 frappe/core/doctype/user_type/user_type.json | 24 ++++++++++++--------
 2 files changed, 16 insertions(+), 17 deletions(-)

diff --git a/frappe/core/doctype/user_type/user_type.js b/frappe/core/doctype/user_type/user_type.js
index c8bd499b58..6b53248fd4 100644
--- a/frappe/core/doctype/user_type/user_type.js
+++ b/frappe/core/doctype/user_type/user_type.js
@@ -3,13 +3,8 @@
 
 frappe.ui.form.on('User Type', {
 	refresh: function(frm) {
-		frm.toggle_display('is_standard', frappe.boot.developer_mode);
-		frm.set_df_property('is_standard', 'read_only', !frappe.boot.developer_mode);
-
-		const fields = ['role', 'apply_user_permission_on', 'user_id_field',
-			'user_doctypes', 'user_type_modules'];
-
-		frm.toggle_display(fields, !frm.doc.is_standard);
+		if (frm.is_new() && !frappe.boot.developer_mode)
+			frm.set_value('is_standard', 1);
 
 		frm.set_query('document_type', 'user_doctypes', function() {
 			return {
diff --git a/frappe/core/doctype/user_type/user_type.json b/frappe/core/doctype/user_type/user_type.json
index 9ea5d5be71..3d6b470af5 100644
--- a/frappe/core/doctype/user_type/user_type.json
+++ b/frappe/core/doctype/user_type/user_type.json
@@ -22,9 +22,11 @@
  "fields": [
   {
    "default": "0",
+   "depends_on": "eval: frappe.boot.developer_mode",
    "fieldname": "is_standard",
    "fieldtype": "Check",
-   "label": "Is Standard"
+   "label": "Is Standard",
+   "read_only_depends_on": "eval: !frappe.boot.developer_mode"
   },
   {
    "depends_on": "eval: !doc.is_standard",
@@ -33,21 +35,21 @@
    "label": "Document Types and Permissions"
   },
   {
+   "depends_on": "eval: !doc.is_standard",
    "fieldname": "user_doctypes",
    "fieldtype": "Table",
    "label": "Document Types",
    "mandatory_depends_on": "eval: !doc.is_standard",
-   "options": "User Document Type",
-   "read_only": 1
+   "options": "User Document Type"
   },
   {
+   "depends_on": "eval: !doc.is_standard",
    "fieldname": "role",
    "fieldtype": "Link",
    "in_list_view": 1,
    "label": "Role",
    "mandatory_depends_on": "eval: !doc.is_standard",
-   "options": "Role",
-   "read_only": 1
+   "options": "Role"
   },
   {
    "fieldname": "select_doctypes",
@@ -62,13 +64,13 @@
    "fieldtype": "Column Break"
   },
   {
+   "depends_on": "eval: !doc.is_standard",
    "description": "Can only list down the document types which has been linked to the User document type.",
    "fieldname": "apply_user_permission_on",
    "fieldtype": "Link",
    "label": "Apply User Permission On",
    "mandatory_depends_on": "eval: !doc.is_standard",
-   "options": "DocType",
-   "read_only": 1
+   "options": "DocType"
   },
   {
    "depends_on": "eval: !doc.is_standard",
@@ -81,8 +83,7 @@
    "fieldname": "user_id_field",
    "fieldtype": "Select",
    "label": "User Id Field",
-   "mandatory_depends_on": "eval: !doc.is_standard",
-   "read_only": 1
+   "mandatory_depends_on": "eval: !doc.is_standard"
   },
   {
    "depends_on": "eval: !doc.is_standard",
@@ -93,6 +94,7 @@
   {
    "fieldname": "user_type_modules",
    "fieldtype": "Table",
+   "label": "User Type Module",
    "no_copy": 1,
    "options": "User Type Module",
    "print_hide": 1,
@@ -107,10 +109,11 @@
  ],
  "index_web_pages_for_search": 1,
  "links": [],
- "modified": "2021-03-12 16:25:18.639050",
+ "modified": "2022-06-09 14:00:36.820306",
  "modified_by": "Administrator",
  "module": "Core",
  "name": "User Type",
+ "naming_rule": "Set by user",
  "owner": "Administrator",
  "permissions": [
   {
@@ -137,5 +140,6 @@
  ],
  "sort_field": "modified",
  "sort_order": "DESC",
+ "states": [],
  "track_changes": 1
 }
\ No newline at end of file