From 458fba8350fd57be024c441fd390916408c6d6c5 Mon Sep 17 00:00:00 2001
From: Suraj Shetty <surajshetty3416@gmail.com>
Date: Sun, 31 Jan 2021 19:48:57 +0530
Subject: [PATCH] fix: Close <li> tag

- Fix formatting
---
 frappe/public/js/frappe/ui/page.js | 28 +++++++++++++++++++---------
 1 file changed, 19 insertions(+), 9 deletions(-)

diff --git a/frappe/public/js/frappe/ui/page.js b/frappe/public/js/frappe/ui/page.js
index 5d86eaf628..25e3924036 100644
--- a/frappe/public/js/frappe/ui/page.js
+++ b/frappe/public/js/frappe/ui/page.js
@@ -417,17 +417,27 @@ frappe.ui.Page = Class.extend({
 
 		if (shortcut) {
 			let shortcut_obj = this.prepare_shortcut_obj(shortcut, click, label);
-			$li = $(`<li><a class="grey-link dropdown-item" href="#" onClick="return false;">
-				${$icon}
-				<span class="menu-item-label">${label}</span>
-				<kbd class="pull-right">
-					<span>${shortcut_obj.shortcut_label}</span>
-				</kbd>
-			</a><li>`);
+			$li = $(`
+				<li>
+					<a class="grey-link dropdown-item" href="#" onClick="return false;">
+						${$icon}
+						<span class="menu-item-label">${label}</span>
+						<kbd class="pull-right">
+							<span>${shortcut_obj.shortcut_label}</span>
+						</kbd>
+					</a>
+				</li>
+			`);
 			frappe.ui.keys.add_shortcut(shortcut_obj);
 		} else {
-			$li = $(`<li><a class="grey-link dropdown-item" href="#" onClick="return false;">
-				${$icon}<span class="menu-item-label">${label}</span></a><li>`);
+			$li = $(`
+				<li>
+					<a class="grey-link dropdown-item" href="#" onClick="return false;">
+						${$icon}
+						<span class="menu-item-label">${label}</span>
+					</a>
+				</li>
+			`);
 		}
 		var $link = $li.find("a").on("click", click);