From 47bcc527f382ea9ed8afa094c259aafa2dbf8bff Mon Sep 17 00:00:00 2001 From: Gavin D'souza Date: Mon, 16 Jan 2023 14:51:31 +0530 Subject: [PATCH] fix: Remove logic short circuit / dont reject fields easily --- frappe/model/db_query.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/frappe/model/db_query.py b/frappe/model/db_query.py index d228c8a017..c7878f703b 100644 --- a/frappe/model/db_query.py +++ b/frappe/model/db_query.py @@ -564,11 +564,6 @@ class DatabaseQuery: permitted_fields = get_permitted_fields(doctype=self.doctype) for i, field in enumerate(self.fields): - # field: like 'name', 'published' - if is_plain_field(field) and field not in permitted_fields: - self.fields.remove(field) - continue - if "distinct" in field.lower(): # field: 'count(distinct `tabPhoto`.name) as total_count' # column: 'tabPhoto.name' @@ -582,9 +577,10 @@ class DatabaseQuery: if column == "*" and not in_function("*", field): self.fields[i : i + 1] = permitted_fields + continue # handle pseudo columns - elif not column: + elif not column or column.isnumeric(): continue # labels / pseudo columns or frappe internals