vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(ux): enable create log for server scripts by default (#35291)

Browse source 
* fix(ux): enable create log for server scripts by default
This commit is contained in:
Hussain Nagaria 2025-12-17 13:36:14 +05:30 • committed by GitHub
parent dce98dc7e4
commit 48b6663a6d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cypress/integration/form.js
View file

@ -69,7 +69,6 @@ context("Form", () => {
// test email validations for set_invalid controller
let website_input = "website.in";
let valid_email = "user@email.com";
let expectBackgroundColor = "rgb(255, 245, 245)";
cy.visit("/desk/contact/new");
cy.fill_field("company_name", "Test Company");

4
frappe/core/doctype/scheduled_job_type/scheduled_job_type.json
View file

@ -47,7 +47,7 @@
},
{
"default": "0",
"depends_on": "eval:[\"All\", \"Cron\"].includes(doc.frequency)",
"depends_on": "eval:([\"All\", \"Cron\"].includes(doc.frequency) || doc.server_script)",
"fieldname": "create_log",
"fieldtype": "Check",
"label": "Create Log"
@ -117,7 +117,7 @@
"link_fieldname": "scheduled_job_type"
}
],
"modified": "2025-06-03 09:26:47.961601",
"modified": "2025-12-17 12:02:56.228336",
"modified_by": "Administrator",
"module": "Core",
"name": "Scheduled Job Type",

4
frappe/core/doctype/server_script/server_script.py
View file

@ -123,7 +123,9 @@ class ServerScript(Document):
if scheduled_script := frappe.db.get_value("Scheduled Job Type", {"server_script": self.name}):
return frappe.get_doc("Scheduled Job Type", scheduled_script)
else:
return frappe.get_doc({"doctype": "Scheduled Job Type", "server_script": self.name})
return frappe.get_doc(
{"doctype": "Scheduled Job Type", "server_script": self.name, "create_log": 1}
)
previous_script_type = self.get_value_before_save("script_type")
if previous_script_type != self.script_type and previous_script_type == "Scheduler Event":