From 4937b3d17f73656c1ae6235f8e0ae5bd55fa16c0 Mon Sep 17 00:00:00 2001
From: RJPvT <48353029+RJPvT@users.noreply.github.com>
Date: Wed, 8 Jun 2022 15:23:14 +0200
Subject: [PATCH] fix: no add/change image-field if user is not allowed

no add/change image-field (dropdown) if user is not allowed to change

(cherry picked from commit 4af5006470739a11ddcf3141c95ae6fb157d6825)
---
 .../js/frappe/form/sidebar/user_image.js      | 20 ++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/frappe/public/js/frappe/form/sidebar/user_image.js b/frappe/public/js/frappe/form/sidebar/user_image.js
index f657cbca02..bd6487fd52 100644
--- a/frappe/public/js/frappe/form/sidebar/user_image.js
+++ b/frappe/public/js/frappe/form/sidebar/user_image.js
@@ -65,15 +65,17 @@ frappe.ui.form.setup_user_image_event = function(frm) {
 		});
 	}
 
-	frm.sidebar.image_wrapper.on('click', ':not(.sidebar-image-actions)', (e) => {
-		let $target = $(e.currentTarget);
-		if ($target.is('a.dropdown-toggle, .dropdown')) {
-			return;
-		}
-		let dropdown = frm.sidebar.image_wrapper.find('.sidebar-image-actions .dropdown');
-		dropdown.toggleClass('open');
-		e.stopPropagation();
-	});
+	if (frm.fields_dict[frm.meta.image_field].df.read_only == 0) {
+	   	frm.sidebar.image_wrapper.on('click', ':not(.sidebar-image-actions)', (e) => {
+			let $target = $(e.currentTarget);
+			if ($target.is('a.dropdown-toggle, .dropdown')) {
+				return;
+			}
+			let dropdown = frm.sidebar.image_wrapper.find('.sidebar-image-actions .dropdown');
+			dropdown.toggleClass('open');
+			e.stopPropagation();
+		});
+	}
 
 	// bind click on image_wrapper
 	frm.sidebar.image_wrapper.on('click', '.sidebar-image-change, .sidebar-image-remove', function(e) {