From 4a0ccf6d76d2858f673d213bb2a765122a68f2d1 Mon Sep 17 00:00:00 2001 From: Raffael Meyer <14891507+barredterra@users.noreply.github.com> Date: Fri, 24 Jan 2025 10:13:46 +0100 Subject: [PATCH] fix: don't skip perm check when Apply Strict User Permissions is enabled (#29916) --- frappe/model/mapper.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/frappe/model/mapper.py b/frappe/model/mapper.py index 8aca4c4380..d19b3dd3c0 100644 --- a/frappe/model/mapper.py +++ b/frappe/model/mapper.py @@ -66,9 +66,6 @@ def get_mapped_doc( ignore_child_tables=False, cached=False, ): - apply_strict_user_permissions = frappe.get_system_settings("apply_strict_user_permissions") - - # main if not target_doc: target_doctype = table_maps[from_doctype]["doctype"] if table_maps[from_doctype].get("on_parent"): @@ -90,7 +87,7 @@ def get_mapped_doc( else: ret_doc = target_doc - if not apply_strict_user_permissions and not ignore_permissions: + if not ignore_permissions: target_doc.check_permission("create") if cached: @@ -173,7 +170,7 @@ def get_mapped_doc( ret_doc.run_method("after_mapping", source_doc) ret_doc.set_onload("load_after_mapping", True) - if apply_strict_user_permissions and not ignore_permissions: + if not ignore_permissions: ret_doc.check_permission("create") return ret_doc