Merge pull request #31410 from gavindsouza/oauth-on_session_creation

fix: Run on_session_creation on OAuth logins
This commit is contained in:
gavin 2025-03-06 15:45:18 +01:00 committed by GitHub
commit 4a9915c70f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 3 additions and 5 deletions

View file

@ -125,9 +125,6 @@ class LoginManager:
if self.login() is False:
return
self.resume = False
# run login triggers
self.run_trigger("on_session_creation")
else:
try:
self.resume = True
@ -233,6 +230,8 @@ class LoginManager:
self.user = frappe.local.session_obj.user
frappe.local.session = frappe.local.session_obj.data
self.clear_active_sessions()
if not resume:
self.run_trigger("on_session_creation")
def clear_active_sessions(self):
"""Clear other sessions of the current user if `deny_multiple_sessions` is not set"""

View file

@ -204,8 +204,7 @@ def login_oauth_user(
http_status_code=403,
)
frappe.local.login_manager.user = user
frappe.local.login_manager.post_login()
frappe.local.login_manager.login_as(user)
# because of a GET request!
frappe.db.commit()