From 4b13d6d7e4c4eae877ba0b1bf63460cc81bbd6cf Mon Sep 17 00:00:00 2001
From: Faris Ansari <netchampfaris@users.noreply.github.com>
Date: Mon, 16 May 2022 13:33:29 +0530
Subject: [PATCH] fix(webform): only title on the page should be h1 (#16880)

Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
---
 frappe/public/scss/website/web_form.scss             |  3 ++-
 .../website/doctype/web_form/templates/web_form.html | 12 ++++++------
 frappe/website/doctype/web_form/test_web_form.py     |  2 +-
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/frappe/public/scss/website/web_form.scss b/frappe/public/scss/website/web_form.scss
index 0dc1e1a805..010182e1e5 100644
--- a/frappe/public/scss/website/web_form.scss
+++ b/frappe/public/scss/website/web_form.scss
@@ -8,7 +8,8 @@
 		.frappe-card {
 			padding: 1rem;
 
-			h3 {
+			h1 {
+				font-size: 1.9rem;
 				margin-top: 0;
 				margin-bottom: 0;
 			}
diff --git a/frappe/website/doctype/web_form/templates/web_form.html b/frappe/website/doctype/web_form/templates/web_form.html
index 6e0374abdb..7dd532421d 100644
--- a/frappe/website/doctype/web_form/templates/web_form.html
+++ b/frappe/website/doctype/web_form/templates/web_form.html
@@ -27,19 +27,19 @@ data-web-form="{{ name }}" data-web-form-doctype="{{ doc_type }}" data-login-req
 	</div>
 
 	<div class="web-form-wrapper" {{ container_attributes() }}></div>
-	<div id="list-filters" class="row mt-4"></div>
-	<div id="list-table" class="list-table pt-4 overflow-auto"></div>
-	<div class="list-view-footer text-right"></div>
+	<div id="list-filters" class="mt-4 row"></div>
+	<div id="list-table" class="pt-4 overflow-auto list-table"></div>
+	<div class="text-right list-view-footer"></div>
 	{% else %}
 	<!-- web form -->
 	<div class="d-flex justify-content-between web-form-head">
-		<h3>{{ _(title) }}</h3>
+		<h1>{{ _(title) }}</h1>
 		<div class="web-form-actions"></div>
 	</div>
 	<div role="form">
-		<div id="introduction" class="text-muted hidden"></div>
+		<div id="introduction" class="hidden text-muted"></div>
 		<div class="web-form-wrapper" {{ container_attributes() }}></div>
-		<div class="web-form-footer text-right"></div>
+		<div class="text-right web-form-footer"></div>
 	</div>
 
 	{% if show_attachments and not frappe.form_dict.new and attachments %}
diff --git a/frappe/website/doctype/web_form/test_web_form.py b/frappe/website/doctype/web_form/test_web_form.py
index f94a2a19e7..5689bdbeef 100644
--- a/frappe/website/doctype/web_form/test_web_form.py
+++ b/frappe/website/doctype/web_form/test_web_form.py
@@ -69,7 +69,7 @@ class TestWebForm(unittest.TestCase):
 
 	def test_webform_render(self):
 		content = get_response_content("request-data")
-		self.assertIn("<h3>Request Data</h3>", content)
+		self.assertIn("<h1>Request Data</h1>", content)
 		self.assertIn('data-doctype="Web Form"', content)
 		self.assertIn('data-path="request-data"', content)
 		self.assertIn('source-type="Generator"', content)