vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(user): use sendmail instead of enqueuing

Browse source
This commit is contained in:
AarDG10 2026-02-04 16:42:59 +05:30
parent b01f0bd303
commit 4b86e92fbc
2 changed files with 9 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
frappe/core/doctype/user/user.py
View file

@ -1468,9 +1468,7 @@ def impersonate(user: str, reason: str):
"User {0} has started an impersonation session as you. <br><br><b>Reason provided:</b> {1}"
).format(escape_html(impersonator), escape_html(reason))
frappe.enqueue(
method="frappe.sendmail",
queue="short",
frappe.sendmail(
recipients=[user_email],
subject=_("Security Alert: Your account is being impersonated"),
content=email_message,

17
frappe/tests/test_email.py
View file

@ -318,15 +318,14 @@ class TestEmail(IntegrationTestCase):
frappe.get_doc({"doctype": "User", "email": target_user, "first_name": "Target"}).insert(
ignore_permissions=True
)
with patch("frappe.enqueue") as mocked_enqueue:
reason = "Testing Security Alert"
impersonate(user=target_user, reason=reason)
self.assertEqual(frappe.session.user, target_user) # test if impersonation worked
_, kwargs = mocked_enqueue.call_args
self.assertEqual(kwargs.get("method"), "frappe.sendmail") # test if email was enqueued
self.assertIn(target_user, kwargs.get("recipients"))
self.assertIn(reason, kwargs.get("content"))
reason = "Testing Security Alert"
impersonate(user=target_user, reason=reason)
self.assertEqual(frappe.session.user, target_user) # test if impersonation worked
self.assertTrue(frappe.db.exists("Activity Log", {"user": target_user, "operation": "Impersonate"}))
email_queued = frappe.db.exists(
"Email Queue Recipient", {"recipient": target_user, "status": "Not Sent"}
)
self.assertTrue(email_queued, f"Impersonation email was not queued for {target_user}")
frappe.db.delete("User", {"email": target_user})