From 4c1a61f085fc42feac0a1b2655a328af6dff800c Mon Sep 17 00:00:00 2001 From: PUGAZHENDHI V <126157273+PugazhendhiVelu@users.noreply.github.com> Date: Mon, 25 Aug 2025 11:58:43 +0530 Subject: [PATCH] fix: validate dot in numeric placeholders (#33739) * fix: validate dot in numeric placeholders * fix: failed test cases --- frappe/model/naming.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/frappe/model/naming.py b/frappe/model/naming.py index 44fe56824c..bc1eb9d0f3 100644 --- a/frappe/model/naming.py +++ b/frappe/model/naming.py @@ -71,6 +71,14 @@ class NamingSeries: exc=InvalidNamingSeriesError, ) + if "#" in self.series and ".#" not in self.series: + frappe.throw( + _( + "Invalid naming series {}: dot (.) missing before the numeric placeholders. Kindly use a format like ABCD.#####." + ).format(frappe.bold(self.series)), + exc=InvalidNamingSeriesError, + ) + def generate_next_name(self, doc: "Document", *, ignore_validate=False) -> str: if not ignore_validate: self.validate()