From 9d6cbd0c15cb45bba0b267716240fb47a98f07b9 Mon Sep 17 00:00:00 2001 From: barredterra <14891507+barredterra@users.noreply.github.com> Date: Wed, 24 Jan 2024 02:41:03 +0100 Subject: [PATCH] fix: typos --- .github/helper/install.sh | 2 +- frappe/core/doctype/data_export/data_export.js | 2 +- .../document_naming_settings/test_document_naming_settings.py | 4 ++-- frappe/core/doctype/user_permission/user_permission_list.js | 2 +- .../integrations/doctype/ldap_settings/test_ldap_settings.py | 2 +- frappe/tests/test_naming.py | 4 ++-- frappe/tests/utils.py | 2 +- frappe/utils/pdf.py | 2 +- frappe/website/doctype/web_form/web_form.js | 2 +- 9 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/helper/install.sh b/.github/helper/install.sh index 5cdcbebe1a..3bba9a2600 100644 --- a/.github/helper/install.sh +++ b/.github/helper/install.sh @@ -66,6 +66,6 @@ bench --site test_site reinstall --yes if [ "$TYPE" == "server" ] then - # wait till assets are built succesfully + # wait till assets are built successfully wait $build_pid fi diff --git a/frappe/core/doctype/data_export/data_export.js b/frappe/core/doctype/data_export/data_export.js index afac4dd3a6..a819ed7fe3 100644 --- a/frappe/core/doctype/data_export/data_export.js +++ b/frappe/core/doctype/data_export/data_export.js @@ -41,7 +41,7 @@ const can_export = (frm) => { if (!doctype) { frappe.msgprint(__("Please select the Document Type.")); } else if (!parent_multicheck_options.length) { - frappe.msgprint(__("Atleast one field of Parent Document Type is mandatory")); + frappe.msgprint(__("At least one field of Parent Document Type is mandatory")); } else { is_valid_form = true; } diff --git a/frappe/core/doctype/document_naming_settings/test_document_naming_settings.py b/frappe/core/doctype/document_naming_settings/test_document_naming_settings.py index d1a6fbe90d..8fc1584aa3 100644 --- a/frappe/core/doctype/document_naming_settings/test_document_naming_settings.py +++ b/frappe/core/doctype/document_naming_settings/test_document_naming_settings.py @@ -40,8 +40,8 @@ class TestNamingSeries(FrappeTestCase): def get_valid_serieses(self): VALID_SERIES = ["SINV-", "SI-.{field}.", "SI-#.###", ""] - exisiting_series = self.dns.get_transactions_and_prefixes()["prefixes"] - return VALID_SERIES + exisiting_series + existing_series = self.dns.get_transactions_and_prefixes()["prefixes"] + return VALID_SERIES + existing_series def test_naming_preview(self): self.dns.transaction_type = self.ns_doctype diff --git a/frappe/core/doctype/user_permission/user_permission_list.js b/frappe/core/doctype/user_permission/user_permission_list.js index ce5e624403..45602b973c 100644 --- a/frappe/core/doctype/user_permission/user_permission_list.js +++ b/frappe/core/doctype/user_permission/user_permission_list.js @@ -121,7 +121,7 @@ frappe.listview_settings["User Permission"] = { callback: function (r) { if (r.message === 1) { frappe.show_alert({ - message: __("User Permissions created sucessfully"), + message: __("User Permissions created successfully"), indicator: "blue", }); } else { diff --git a/frappe/integrations/doctype/ldap_settings/test_ldap_settings.py b/frappe/integrations/doctype/ldap_settings/test_ldap_settings.py index 2e20367990..8f9ebf712c 100644 --- a/frappe/integrations/doctype/ldap_settings/test_ldap_settings.py +++ b/frappe/integrations/doctype/ldap_settings/test_ldap_settings.py @@ -438,7 +438,7 @@ class LDAP_TestCase: for user_role in updated_user_roles: # match each users role mapped to ldap groups self.assertTrue( role_to_group_map[user_role] in test_user_data[test_user], - f"during sync_roles(), the user was given role {user_role} which should not have occured", + f"during sync_roles(), the user was given role {user_role} which should not have occurred", ) @mock_ldap_connection diff --git a/frappe/tests/test_naming.py b/frappe/tests/test_naming.py index 721cfa42fc..19229ac881 100644 --- a/frappe/tests/test_naming.py +++ b/frappe/tests/test_naming.py @@ -319,8 +319,8 @@ class TestNaming(FrappeTestCase): def test_naming_series_validation(self): dns = frappe.get_doc("Document Naming Settings") - exisiting_series = dns.get_transactions_and_prefixes()["prefixes"] - valid = ["SINV-", "SI-.{field}.", "SI-#.###", ""] + exisiting_series + existing_series = dns.get_transactions_and_prefixes()["prefixes"] + valid = ["SINV-", "SI-.{field}.", "SI-#.###", ""] + existing_series invalid = ["$INV-", r"WINDOWS\NAMING"] for series in valid: diff --git a/frappe/tests/utils.py b/frappe/tests/utils.py index 2101cfa657..d42a6d3893 100644 --- a/frappe/tests/utils.py +++ b/frappe/tests/utils.py @@ -226,7 +226,7 @@ def _restore_thread_locals(flags): @contextmanager def change_settings(doctype, settings_dict=None, /, **settings): """A context manager to ensure that settings are changed before running - function and restored after running it regardless of exceptions occured. + function and restored after running it regardless of exceptions occurred. This is useful in tests where you want to make changes in a function but don't retain those changes. import and use as decorator to cover full function or using `with` statement. diff --git a/frappe/utils/pdf.py b/frappe/utils/pdf.py index 24b6896620..05bcccfb88 100644 --- a/frappe/utils/pdf.py +++ b/frappe/utils/pdf.py @@ -54,7 +54,7 @@ def pdf_body_html(template, args, **kwargs): def _guess_template_error_line_number(template) -> int | None: - """Guess line on which exception occured from current traceback.""" + """Guess line on which exception occurred from current traceback.""" with contextlib.suppress(Exception): import sys import traceback diff --git a/frappe/website/doctype/web_form/web_form.js b/frappe/website/doctype/web_form/web_form.js index dd73f09a0c..af978ad0fa 100644 --- a/frappe/website/doctype/web_form/web_form.js +++ b/frappe/website/doctype/web_form/web_form.js @@ -61,7 +61,7 @@ frappe.ui.form.on("Web Form", { if (!frm.doc.web_form_fields) { frm.scroll_to_field("web_form_fields"); - frappe.throw(__("Atleast one field is required in Web Form Fields Table")); + frappe.throw(__("At least one field is required in Web Form Fields Table")); } let page_break_count = frm.doc.web_form_fields.filter(