From 6479163899dedd2b3010be9a11f4ee71cc0e074a Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Mon, 21 Nov 2022 19:28:54 +0530 Subject: [PATCH 1/2] fix(file): set fieldname to table fieldname because files are always attached to parent --- frappe/public/js/frappe/form/controls/attach.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/controls/attach.js b/frappe/public/js/frappe/form/controls/attach.js index fc8aef72b8..bbd8129b8d 100644 --- a/frappe/public/js/frappe/form/controls/attach.js +++ b/frappe/public/js/frappe/form/controls/attach.js @@ -79,7 +79,11 @@ frappe.ui.form.ControlAttach = class ControlAttach extends frappe.ui.form.Contro if (this.frm) { options.doctype = this.frm.doctype; options.docname = this.frm.docname; - options.fieldname = this.df.fieldname; + if (this.grid) { + options.fieldname = this.grid.control.df.fieldname; + } else { + options.fieldname = this.df.fieldname; + } options.make_attachments_public = this.frm.meta.make_attachments_public; } From 45230cf938943b8cab627f81dfddbd223592574e Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Tue, 22 Nov 2022 00:00:37 +0530 Subject: [PATCH 2/2] fix: succinct version Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com> --- frappe/public/js/frappe/form/controls/attach.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/frappe/public/js/frappe/form/controls/attach.js b/frappe/public/js/frappe/form/controls/attach.js index bbd8129b8d..0f40a0a829 100644 --- a/frappe/public/js/frappe/form/controls/attach.js +++ b/frappe/public/js/frappe/form/controls/attach.js @@ -79,11 +79,7 @@ frappe.ui.form.ControlAttach = class ControlAttach extends frappe.ui.form.Contro if (this.frm) { options.doctype = this.frm.doctype; options.docname = this.frm.docname; - if (this.grid) { - options.fieldname = this.grid.control.df.fieldname; - } else { - options.fieldname = this.df.fieldname; - } + options.fieldname = this.grid ? this.grid.df.fieldname : this.df.fieldname; options.make_attachments_public = this.frm.meta.make_attachments_public; }