From 4e188ec531ce3764f128da3bc406b60141e06a45 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Mon, 8 Jan 2024 15:37:04 +0530 Subject: [PATCH] fix: webhook error logging fails (#24172) These variables can be unset if webhook fails while creating them. --- frappe/integrations/doctype/webhook/webhook.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/frappe/integrations/doctype/webhook/webhook.py b/frappe/integrations/doctype/webhook/webhook.py index 3ecfe6cd61..64d38a2ae7 100644 --- a/frappe/integrations/doctype/webhook/webhook.py +++ b/frappe/integrations/doctype/webhook/webhook.py @@ -153,15 +153,14 @@ def get_context(doc): def enqueue_webhook(doc, webhook) -> None: + request_url = headers = data = None try: webhook: Webhook = frappe.get_doc("Webhook", webhook.get("name")) - headers = get_webhook_headers(doc, webhook) - data = get_webhook_data(doc, webhook) - + request_url = webhook.request_url if webhook.is_dynamic_url: request_url = frappe.render_template(webhook.request_url, get_context(doc)) - else: - request_url = webhook.request_url + headers = get_webhook_headers(doc, webhook) + data = get_webhook_data(doc, webhook) except Exception as e: frappe.logger().debug({"enqueue_webhook_error": e})