From 4ec2d5f00d5879699fc37f91b60cc0f52874d404 Mon Sep 17 00:00:00 2001 From: Shariq Ansari Date: Thu, 15 Jun 2023 12:48:55 +0530 Subject: [PATCH] fix: commit after successfull deletion of all tasks --- frappe/desk/reportview.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/frappe/desk/reportview.py b/frappe/desk/reportview.py index 071b6e7e61..6efd7d8658 100644 --- a/frappe/desk/reportview.py +++ b/frappe/desk/reportview.py @@ -489,8 +489,6 @@ def delete_bulk(doctype, items): dict(progress=[i + 1, len(items)], title=_("Deleting {0}").format(doctype), description=d), user=frappe.session.user, ) - # Commit after successful deletion - frappe.db.commit() except Exception: # rollback if any record failed to delete # if not rollbacked, queries get committed on after_request method in app.py @@ -499,6 +497,9 @@ def delete_bulk(doctype, items): if undeleted_items and len(items) != len(undeleted_items): frappe.clear_messages() delete_bulk(doctype, undeleted_items) + else: + # Commit after successful deletion + frappe.db.commit() @frappe.whitelist()