From 4f08c346965ada26885ca207a15b034e6834c972 Mon Sep 17 00:00:00 2001 From: Ejaaz Khan <67804911+iamejaaz@users.noreply.github.com> Date: Wed, 14 May 2025 10:48:46 +0530 Subject: [PATCH] Revert "fix: don't allow attaching an file invalid url" --- .../js/frappe/file_uploader/FileUploader.vue | 25 +------------------ frappe/www/printview.py | 3 +-- 2 files changed, 2 insertions(+), 26 deletions(-) diff --git a/frappe/public/js/frappe/file_uploader/FileUploader.vue b/frappe/public/js/frappe/file_uploader/FileUploader.vue index 530fbaba56..b94b964876 100644 --- a/frappe/public/js/frappe/file_uploader/FileUploader.vue +++ b/frappe/public/js/frappe/file_uploader/FileUploader.vue @@ -524,37 +524,14 @@ function upload_via_file_browser() { library_file_name: selected_file.value, }); } - -async function validate_html_url(url) { - try { - let response = await fetch(url, { method: "HEAD" }); - let contentType = response.headers.get("Content-Type"); - - if (contentType && contentType.includes("text/html")) { - return false; - } - } catch (error) { - console.log("Error fetching URL:", error); - } - return true; -} - -async function upload_via_web_link() { +function upload_via_web_link() { let file_url = web_link.value.url; if (!file_url) { frappe.msgprint(__("Invalid URL")); close_dialog.value = true; return Promise.reject(); } - file_url = decodeURI(file_url); - const is_valid = await validate_html_url(file_url); - - if (!is_valid) { - frappe.msgprint(__("Invalid or unsupported URL")); - return Promise.reject(); - } - close_dialog.value = true; return upload_file({ file_url, diff --git a/frappe/www/printview.py b/frappe/www/printview.py index a1d97d30f4..cb973d785e 100644 --- a/frappe/www/printview.py +++ b/frappe/www/printview.py @@ -78,8 +78,7 @@ def get_context(context) -> PrintContext: body = get_html( doctype=frappe.form_dict.doctype, name=frappe.form_dict.name, print_format=print_format.name ) - if cint(frappe.form_dict.trigger_print): - body += trigger_print_script + body += trigger_print_script else: body = get_rendered_template( doc,