vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: follow single responsibility principle

Browse source
This commit is contained in:
Mangesh-Khairnar 2020-10-15 19:01:40 +05:30
parent 6274ec19a7
commit 4f3ec03fd6
1 changed files with 7 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
frappe/integrations/doctype/integration_request/integration_request.py
View file

@ -23,19 +23,16 @@ class IntegrationRequest(Document):
self.save(ignore_permissions=True)
frappe.db.commit()
def handle_sucess(self, response):
def handle_success(self, response):
"""update the output field with the response along with the relevant status"""
self.process_response("output", response)
if isinstance(response, string_types):
response = json.loads(response)
self.db_set("status", "Completed")
self.db_set("output", json.dumps(response, default=json_handler))
def handle_failure(self, response):
"""update the error field with the response along with the relevant status"""
self.process_response("error", response)
def process_response(self, ref_field, response):
"""Update the response in integration request with status based on reference"""
if isinstance(response, string_types):
response = json.loads(response)
status = "Completed" if ref_field == "output" else "Failed"
self.db_set(ref_field, json.dumps(response, default=json_handler))
self.db_set("status", status)
self.db_set("status", "Failed")
self.db_set("error", json.dumps(response, default=json_handler))