vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: Allow field of submitted doc to edit if field has allow_on_submit enabled

Browse source
This commit is contained in:
Suraj Shetty 2019-12-10 10:55:36 +05:30
parent acc27a147a
commit 4f477cbc94
1 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
frappe/public/js/frappe/views/reports/report_view.js
View file

@ -615,15 +615,18 @@ frappe.views.ReportView = class ReportView extends frappe.views.ListView {
}
is_editable(df, data) {
if (!df || data.docstatus !== 0) return false;
const is_standard_field = frappe.model.std_fields_list.includes(df.fieldname);
const can_edit = !(
is_standard_field
|| df.read_only
|| df.hidden
|| !frappe.model.can_write(this.doctype)
);
return can_edit;
if (df
&& frappe.model.can_write(this.doctype)
// not a submitted doc or field is allowed to edit after submit
&& (data.docstatus !== 1 || df.allow_on_submit)
// not a cancelled doc
&& data.docstatus !== 2
&& !df.read_only
&& !df.hidden
// not a standard field i.e., owner, modified_by, etc.
&& !frappe.model.std_fields_list.includes(df.fieldname))
return true;
return false;
}
get_data(values) {