vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: Never query flag_print_sql in developer_mode=0 (#28884)

Browse source 
Unnecessary overhead and need to disable this everytime I want to get
realistic performance numbers out.

All the performance affecting toggles should be directly controlled by
just `developer_mode` alone.
This commit is contained in:
Ankush Menat 2024-12-23 19:27:01 +05:30 • committed by GitHub
parent f4407c84c7
commit 4f628ca091
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
frappe/__init__.py
View file

@ -522,7 +522,10 @@ def errprint(msg: str) -> None:
def print_sql(enable: bool = True) -> None:
return cache.set_value("flag_print_sql", enable)
if frappe.conf.allow_tests and frappe.conf.developer_mode:
cache.set_value("flag_print_sql", enable)
else:
frappe.throw("`frappe.print_sql` only works in `developer_mode` with `allow_tests` enabled on site.")
def log(msg: str) -> None:

6
frappe/database/database.py
View file

@ -339,7 +339,11 @@ class Database:
"""Takes the query and logs it to various interfaces according to the settings."""
_query = None
if frappe.conf.allow_tests and frappe.cache.get_value("flag_print_sql"):
if (
frappe.conf.allow_tests
and frappe.conf.developer_mode
and frappe.cache.get_value("flag_print_sql")
):
_query = _query or str(mogrified_query)
print(_query)