vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

refactor: more changes

Browse source
This commit is contained in:
ruthra kumar 2025-02-07 17:25:01 +05:30
parent cb6e561edb
commit 4fcde7d3d4
1 changed files with 17 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
frappe/core/report/prepared_report_analytics/prepared_report_analytics.py
View file

@ -56,13 +56,13 @@ def get_columns(filters) -> list[dict]:
{
"label": _("Runtime in Minutes") if filters.in_minutes else _("Runtime in Seconds"),
"fieldname": "runtime",
"fieldtype": "Int",
"fieldtype": "float",
"width": 250,
},
{
"label": _("Peak Memory Usage"),
"label": _("Memory Usage in MB"),
"fieldname": "peak_memory_usage",
"fieldtype": "Int",
"fieldtype": "float",
"width": 250,
},
]
@ -81,20 +81,24 @@ def get_data(filters) -> list[list]:
if filters.report:
conditions.append(pr.report_name.like(f"%{filters.report}%"))
res: list = (
qb.from_(pr)
.select(pr.name, pr.report_name, pr.creation, pr.report_end_time, pr.peak_memory_usage)
.where(Criterion.all(conditions))
.orderby(pr.creation, order=Order.desc)
.run(as_dict=True)
)
divisor = 1
if filters.in_minutes:
divisor = 60
for x in res:
x.runtime = ((x.report_end_time - x.creation).total_seconds()) / divisor
res: list = (
qb.from_(pr)
.select(
pr.name,
pr.report_name,
pr.creation,
pr.report_end_time,
(pr.peak_memory_usage / 1024).as_("peak_memory_usage"),
)
.select(((pr.report_end_time - pr.creation) / divisor).as_("runtime"))
.where(Criterion.all(conditions))
.orderby(qb.Field("runtime"), order=Order.desc)
.run(as_dict=True)
)
res.sort(key=lambda x: x.runtime, reverse=True)
if filters.top_10: