vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(sqlite): don't consider implicit commit for begin for now

Browse source 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2025-03-17 16:41:34 +05:30
parent 5d566d03a0
commit 50fae37072
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
frappe/database/sqlite/database.py
View file

@ -6,16 +6,15 @@ from pathlib import Path
import frappe
from frappe.database.database import (
IMPLICIT_COMMIT_QUERY_TYPES,
TRANSACTION_DISABLED_MSG,
Database,
ImplicitCommitError,
is_query_type,
)
from frappe.database.sqlite.schema import SQLiteTable
from frappe.utils import get_datetime, get_table_name
_PARAM_COMP = re.compile(r"%\([\w]*\)s")
IMPLICIT_COMMIT_QUERY_TYPES = frozenset(("start", "alter", "drop", "create", "truncate"))
class SQLiteExceptionUtil:
@ -510,6 +509,10 @@ class SQLiteDatabase(SQLiteExceptionUtil, Database):
self.sql_ddl(f"DELETE FROM `{table}`")
self.sql_ddl(f"DELETE FROM sqlite_sequence WHERE name='{table}'")
def check_implicit_commit(self, query: str, query_type: str):
if query_type in IMPLICIT_COMMIT_QUERY_TYPES and self.transaction_writes:
raise ImplicitCommitError("This statement can cause implicit commit", query)
def modify_query(query):
"""