vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

Merge pull request #13497 from shariquerik/report_view_scroll_fix

Browse source 
fix: Report View single vertical scrollbar
This commit is contained in:
mergify[bot] 2021-08-05 05:50:19 +00:00 • committed by GitHub
commit 514455d1b7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 31 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
frappe/public/js/frappe/views/reports/query_report.js
View file

@ -518,6 +518,9 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList {
} else {
this.page.show_form();
}
this.page.body[0].style.setProperty('--report-filter-height', this.page.page_form.css('height'));
this.page.body.parent().css('margin-bottom', 'unset');
}
set_filters(filters) {

2
frappe/public/js/frappe/views/reports/report_view.js
View file

@ -49,6 +49,8 @@ frappe.views.ReportView = class ReportView extends frappe.views.ListView {
this.setup_columns();
super.setup_new_doc_event();
this.page.main.addClass('report-view');
this.page.body[0].style.setProperty('--report-filter-height', this.page.page_form.css('height'));
this.page.body.parent().css('margin-bottom', 'unset');
}
toggle_side_bar() {

29
frappe/public/scss/desk/report.scss
View file

@ -84,14 +84,37 @@
margin-bottom: 10px;
}
.layout-main-section .frappe-card {
--report-filter-height: 0px;
}
.report-wrapper {
overflow: auto;
.datatable {
height: calc(100vh - var(--report-filter-height) - 205px);
.dt-scrollable {
height: calc(100vh - var(--report-filter-height) - 275px);
}
}
}
.report-view {
.dt-row:last-child:not(.dt-row-filter) {
.dt-cell {
border-bottom: 1px solid var(--border-color);
.result {
min-height: 50vh !important;
.dt-row:last-child:not(.dt-row-filter) {
.dt-cell {
border-bottom: 1px solid var(--border-color);
}
}
.datatable {
height: calc(100vh - var(--report-filter-height) - 225px);
.dt-scrollable {
height: calc(100vh - var(--report-filter-height) - 295px);
}
}
}
}