From 515f56a689aef1f94f22ca30d3e50c0dd53cf598 Mon Sep 17 00:00:00 2001 From: Suraj Shetty Date: Thu, 13 Jan 2022 12:36:15 +0530 Subject: [PATCH] style: Fix sider warnings --- frappe/public/js/frappe/form/form.js | 10 +++---- frappe/public/scss/common/controls.scss | 39 ++++++++++++------------- 2 files changed, 23 insertions(+), 26 deletions(-) diff --git a/frappe/public/js/frappe/form/form.js b/frappe/public/js/frappe/form/form.js index 4ace5ec199..81677c519f 100644 --- a/frappe/public/js/frappe/form/form.js +++ b/frappe/public/js/frappe/form/form.js @@ -891,7 +891,7 @@ frappe.ui.form.Form = class FrappeForm { } else { frappe.confirm(__("Permanently Cancel {0}?", [this.docname]), cancel_doc, this.handle_save_fail(btn, on_error)); } - }; + } savetrash() { this.validate_form_action("Delete"); @@ -1172,8 +1172,8 @@ frappe.ui.form.Form = class FrappeForm { click: () => { this.call("get_new_document_key").then(res => { let key = res.message; - share_document_url_dialog.set_value("link", this.get_share_link(key)) - }) + share_document_url_dialog.set_value("link", this.get_share_link(key)); + }); } }, { fieldname: "link", @@ -1184,8 +1184,8 @@ frappe.ui.form.Form = class FrappeForm { }], size: "small", title: __("Share {} Link", [this.doctype]), - }) - share_document_url_dialog.show() + }); + share_document_url_dialog.show(); } get_share_link(key) { diff --git a/frappe/public/scss/common/controls.scss b/frappe/public/scss/common/controls.scss index 3cbc447d8f..60a790681b 100644 --- a/frappe/public/scss/common/controls.scss +++ b/frappe/public/scss/common/controls.scss @@ -126,6 +126,24 @@ select.form-control { margin-bottom: 0; } } + .action-btn { + position: absolute; + top: 4px; + right: 4px; + padding: 3px; + z-index: 3; + } + + button.action-btn { + padding: 3px 5px; + background-color: var(--fg-color); + } + + .link-btn { + @extend .action-btn; + background-color: none; + display: none; + } } .frappe-control:not([data-fieldtype='MultiSelectPills']):not([data-fieldtype='Table MultiSelect']) { @@ -288,27 +306,6 @@ textarea.form-control { position: relative; } -.frappe-control { - .action-btn { - position: absolute; - top: 4px; - right: 4px; - padding: 3px; - z-index: 3; - } - - button.action-btn { - padding: 3px 5px; - background-color: var(--fg-color); - } - - .link-btn { - @extend .action-btn; - background-color: none; - display: none; - } -} - .phone-btn { position: absolute; top: 4px;